On Wed, 8 Feb 2023 12:46:48 GMT, Jaikiran Pai <[email protected]> wrote:
>> Conor Cleary has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains eight additional >> commits since the last revision: >> >> - Merge branch 'JDK-8296410' of https://github.com/c-cleary/jdk into >> JDK-8296410 >> - 8296410: Updated copyright header >> - 8296410: Use empty trailers instead of sample ones >> - 8296410: HttpClient throws java.io.IOException: no statuscode in response >> for HTTP2 >> - 8296410: Made test compatible with new test library structure >> - Merge branch 'master' of https://github.com/c-cleary/jdk into JDK-8296410 >> - 8296410: Push Promise Test Case Modifications >> - 8296410: HttpClient throws java.io.IOException: no statuscode in response >> for HTTP2 > > test/jdk/java/net/httpclient/http2/TrailingHeadersTest.java line 154: > >> 152: private void verifyPushPromise() { >> 153: if (pushPromiseMap.size() > 1) { >> 154: throw new TestException("Push Promise map size is greater >> than 1"); > > Would replacing this `if` block with a `assertEquals(pushPromizeMap.size(), > 1, "....");` be better? That way, the actual size of the map would also get > printed, if this check failed for whatever reason. This has been updated to a assertEquals() as suggested. Marking as resolved ------------- PR: https://git.openjdk.org/jdk/pull/12028
