On Wed, 8 Feb 2023 14:32:22 GMT, Daniel Fuchs <[email protected]> wrote:
> Hello Conor, something is odd with this PR or the generated webrev. Neither > the GitHub UI nor the https://github.com/openjdk/jdk/pull/12028.diff list or > show `test/jdk/java/net/httpclient/http2/IdleConnectionTimeoutTest.java` as a > changed/updated file. However, the webrev version 2 (full) > https://openjdk.github.io/cr/?repo=jdk&pr=12028&range=02, listed in the > comment of this PR [#12028 > (comment)](https://github.com/openjdk/jdk/pull/12028#issuecomment-1385604175) > shows considerable changes to that > `test/jdk/java/net/httpclient/http2/IdleConnectionTimeoutTest.java` file. WRT the absence of this additional file in the webrev, this is due to a forced removal of the file which was accidentally added to this branch. A forced push is often discouraged (and something I'll avoid in future) for this very reason as it erases the related deletions from the commit history. In this case it was the easiest option but had the side effect described. Either way the file is no longer present is not relevant to the PR which should now merge with the mainline cleanly. ------------- PR: https://git.openjdk.org/jdk/pull/12028
