On Wed, 8 Feb 2023 12:37:37 GMT, Jaikiran Pai <[email protected]> wrote:
>> Conor Cleary has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains eight additional >> commits since the last revision: >> >> - Merge branch 'JDK-8296410' of https://github.com/c-cleary/jdk into >> JDK-8296410 >> - 8296410: Updated copyright header >> - 8296410: Use empty trailers instead of sample ones >> - 8296410: HttpClient throws java.io.IOException: no statuscode in response >> for HTTP2 >> - 8296410: Made test compatible with new test library structure >> - Merge branch 'master' of https://github.com/c-cleary/jdk into JDK-8296410 >> - 8296410: Push Promise Test Case Modifications >> - 8296410: HttpClient throws java.io.IOException: no statuscode in response >> for HTTP2 > > test/jdk/java/net/httpclient/http2/TrailingHeadersTest.java line 31: > >> 29: * @library /test/jdk/java/net/httpclient/lib >> 30: * @build jdk.httpclient.test.lib.http2.Http2TestServer >> 31: * @modules java.base/sun.net.www.http > > With the recent changes to the mainline, these common modules for httpclietn > tests, should no longer be necessary to be repeated in each test. They get > added by default since they are listed in the `TEST.properties` for > httpclient tests. Got it, can see that in the output now when I've removed the `@modules` argument. 👍 ------------- PR: https://git.openjdk.org/jdk/pull/12028
