On Mon, 13 Jan 2025 14:35:43 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Alan's review - update skip reason
>
> test/jdk/java/net/DatagramSocket/InterruptibleDatagramSocket.java line 102:
>
>> 100: public static void main(String[] args) throws Exception {
>> 101: if (Thread.currentThread().isVirtual()) {
>> 102: throw new jtreg.SkippedException("skipping test execution
>> through a virtual thread");
>
> Throwing .SkippedException is good but "through a virtual thread" looks a bit
> strange, maybe say that the main thread is a virtual thread or the test can
> only be run in a platform thread.
Done - I've updated the PR to reword this message.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23074#discussion_r1913297202
