On Mon, 13 Jan 2025 14:42:04 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Can I please get a review for this test-only change which proposes to skip >> this test when the `main()` is launched through a virtual thread? >> >> This test was introduced in https://bugs.openjdk.org/browse/JDK-8233018 , >> before virtual threads were introduced. In its current form the test doesn't >> take into account the specification of `DatagramSocket.receive()` when a >> virtual thread is doing the `receive()`. There's already the >> `test/jdk/java/net/vthread/BlockingSocketOps.java` test which exercises the >> `receive()` through a virtual thread and verifies its specified behaviour, >> so we can skip this `InterruptibleDatagramSocket` test when a virtual thread >> is involved. >> >> With the proposed change, the test no longer fails and is reported as >> skipped by jtreg. > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last revision: > > Alan's review - update skip reason Marked as reviewed by lmesnik (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/23074#pullrequestreview-2547132609
