On Tue, 14 Jan 2025 01:44:53 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> There was some discussion about this in the JBS issue. >> BlockingSocketOps.testDatagramSocketReceiveInterrupt tests the scenario for >> virtual threads so it would be a duplicate test. It doesn't matter, skipping >> or changing it is fine. > > Hello Daniel, My initial idea was to change this test the exact same way as > you propose. However, as I note in the JBS issue, the test fails with virtual > threads even then: > >> The test expects the SocketException that gets thrown in such cases to have >> a exception cause of ClosedByInterruptException. >> ... >> I don't see that specified in the DatagramSocket.receive(), so it might be >> that we will have to re-evaluate that test code separately. > > I did not want to block any of Leonid's testing work in this area so I > decided to skip this test for now. I plan to re-evaluate this test code as a > separate task. Makes sense. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23074#discussion_r1915013194
