On Mon, 13 Jan 2025 14:22:40 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
> Can I please get a review for this test-only change which proposes to skip > this test when the `main()` is launched through a virtual thread? > > This test was introduced in https://bugs.openjdk.org/browse/JDK-8233018 , > before virtual threads were introduced. In its current form the test doesn't > take into account the specification of `DatagramSocket.receive()` when a > virtual thread is doing the `receive()`. There's already the > `test/jdk/java/net/vthread/BlockingSocketOps.java` test which exercises the > `receive()` through a virtual thread and verifies its specified behaviour, so > we can skip this `InterruptibleDatagramSocket` test when a virtual thread is > involved. > > With the proposed change, the test no longer fails and is reported as skipped > by jtreg. This pull request has now been integrated. Changeset: 35be4a43 Author: Jaikiran Pai <j...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/35be4a432b55070f53a6f1aa74994ffb70f07947 Stats: 6 lines in 1 file changed: 5 ins; 0 del; 1 mod 8347173: java/net/DatagramSocket/InterruptibleDatagramSocket.java fails with virtual thread factory Reviewed-by: alanb, lmesnik, dfuchs ------------- PR: https://git.openjdk.org/jdk/pull/23074
