On Mon, 24 Mar 2025 10:23:41 GMT, Volkan Yazici <[email protected]> wrote:
>> Adds `HttpResponse::connectionLabel` method that provides an identifier for
>> the connection.
>>
>> **Implementation note:** The feature is facilitated by
>> `HttpConnection::label`, which should not be confused with
>> `HttpConnection::id`. This distinction is explained in the JavaDoc of both
>> properties.
>
> Volkan Yazici has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Add import for `java.net.http.HttpClient.Version` in
> `HttpResponseConnectionLabelTest`
> - Fix indentation
src/java.net.http/share/classes/java/net/http/HttpResponse.java line 108:
> 106: * The format of the string is opaque, but the content should be
> unique
> 107: * for the lifetime of the {@link HttpClient} instance.
> 108: *
How about changing the wording to something like:
The format of the string is opaque, but the value will be fixed and unique for
any connection, for the lifetime of its {@link HttpClient instance.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24154#discussion_r2012290317
