On Wed, 26 Mar 2025 10:49:06 GMT, Volkan Yazici <[email protected]> wrote:
>> Adds `HttpResponse::connectionLabel` method that provides an identifier for
>> the connection.
>>
>> **Implementation note:** The feature is facilitated by
>> `HttpConnection::label`, which should not be confused with
>> `HttpConnection::id`. This distinction is explained in the JavaDoc of both
>> properties.
>
> Volkan Yazici has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Improve JavaDoc
src/java.net.http/share/classes/jdk/internal/net/http/HttpConnection.java line
121:
> 119: * {@link HttpResponse#connectionLabel()
> HttpResponse::connectionLabel}}
> 120: */
> 121: public String label() {
Perhaps make this method `final`?
src/java.net.http/share/classes/jdk/internal/net/http/HttpResponseImpl.java
line 44:
> 42: * The implementation class for HttpResponse
> 43: */
> 44: class HttpResponseImpl<T> implements HttpResponse<T>, RawChannel.Provider
> {
The copyright year on this file will need an update.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24154#discussion_r2016498947
PR Review Comment: https://git.openjdk.org/jdk/pull/24154#discussion_r2016502574
