On Tue, 25 Mar 2025 14:53:09 GMT, Michael McMahon <micha...@openjdk.org> wrote:
>> Volkan Yazici has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Add import for `java.net.http.HttpClient.Version` in >> `HttpResponseConnectionLabelTest` >> - Fix indentation > > src/java.net.http/share/classes/java/net/http/HttpResponse.java line 108: > >> 106: * The format of the string is opaque, but the content should be >> unique >> 107: * for the lifetime of the {@link HttpClient} instance. >> 108: * > > How about changing the wording to something like: > > The format of the string is opaque, but the value will be fixed and unique > for any connection, for the lifetime of its {@link HttpClient instance. How about: The format of the string is opaque, but the value is fixed and unique for any connection in the scope of the associated {@link HttpClient} instance. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24154#discussion_r2012370174