On Thu, 27 Mar 2025 13:52:13 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> src/java.net.http/share/classes/jdk/internal/net/http/HttpConnection.java >> line 121: >> >>> 119: * {@link HttpResponse#connectionLabel() >>> HttpResponse::connectionLabel}} >>> 120: */ >>> 121: public String label() { >> >> Perhaps make this method `final`? > > Maybe not. We could want to extend it to give an indication that the > connection is TCP or TLS - or Quic in the future... Made it `final` in 883135d8edc2f2a892152e42eda924d65686bc7a. Since the code is in an internal package, we can always relax it if needed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24154#discussion_r2023531007