On Wed, 4 Nov 2026 11:24:01 GMT, Volkan Yazici <[email protected]> wrote:

>> `src/jdk.httpserver/share/classes/module-info.java` documents that 
>> `sun.net.httpserver.maxReqHeaderSize` defaults to `393216 or 384kB`. This 
>> doesn't match the implementation 
>> `sun.net.httpserver.ServerConfig#DEFAULT_MAX_REQ_HEADER_SIZE`, which is `380 
>> * 1024`, i.e., `389120 or 380kB`. Fix the default documented in 
>> `module-info.java`.
>> 
>> ---------
>> - [X] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Volkan Yazici has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Add `MaxReqHeaderSizePropertyTest`

Changes requested by dfuchs (Reviewer).

test/jdk/com/sun/net/httpserver/property/MaxReqHeaderSizePropertyTest.java line 
54:

> 52: /*
> 53:  * @test id=default
> 54:  * @bug 8295785

Suggestion:

 * @bug 8396660

test/jdk/com/sun/net/httpserver/property/MaxReqHeaderSizePropertyTest.java line 
66:

> 64: /*
> 65:  * @test id=200
> 66:  * @bug 8295785

Suggestion:

 * @bug 8396660

-------------

PR Review: https://git.openjdk.org/jdk/pull/33715#pullrequestreview-5767414514
PR Review Comment: https://git.openjdk.org/jdk/pull/33715#discussion_r4466806297
PR Review Comment: https://git.openjdk.org/jdk/pull/33715#discussion_r4466810076

Reply via email to