On Thu, 5 Nov 2026 09:39:32 GMT, Jaikiran Pai <[email protected]> wrote:

>> Volkan Yazici has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Change the default to 384kB
>
> test/jdk/com/sun/net/httpserver/property/MaxReqHeaderSizePropertyTest.java 
> line 97:
> 
>> 95:                     .getHandlers()[0]       // 2. Get its first handler 
>> (by default it's a `ConsoleHandler`)
>> 96:                     .setLevel(Level.ALL);   // 3. Sets its level to 
>> `ALL` (by default it's `INFO`)
>> 97:         }
> 
> I haven't seen us using Loggers in our tests frequently. Is there something 
> specific in this test that would require logger and a test specific 
> `test.enableLogging` system property to enable it?

It is a troubleshooting convenience to enable `HttpServer` logging while 
running the test:

    make test \
        
TEST=test/jdk/com/sun/net/httpserver/property/MaxReqHeaderSizePropertyTest.java 
\
        JTREG="JAVA_OPTIONS=-Dtest.enableLogging"

> test/jdk/com/sun/net/httpserver/property/MaxReqHeaderSizePropertyTest.java 
> line 147:
> 
>> 145:         args.add(Arguments.of(
>> 146:                 "at limit", true,
>> 147:                 
>> createRequestHeaderLinesLeavingRoomFor50MoreCharacters(lines -> {
> 
> Nit - the method name is very large. I think for descriptions like this, a 
> smaller method name with a brief comment on the method is enough.

Shortened the method name in 01c567a1ef5.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33715#discussion_r4480647657
PR Review Comment: https://git.openjdk.org/jdk/pull/33715#discussion_r4480625528

Reply via email to