> `src/jdk.httpserver/share/classes/module-info.java` documents that 
> `sun.net.httpserver.maxReqHeaderSize` defaults to `393216 or 384kB`.
> This doesn't match the implementation 
> `sun.net.httpserver.ServerConfig#DEFAULT_MAX_REQ_HEADER_SIZE`, which is `380 
> * 1024`, i.e., `389120 or 380kB`.
> 
> Note that the `jdk.http.maxHeaderSize` system property, used by `HttpClient`, 
> also defaults to `393216 or 384kB`.
> The `380` hardcoded in `DEFAULT_MAX_REQ_HEADER_SIZE` is a typo.
> Fix `DEFAULT_MAX_REQ_HEADER_SIZE` to `384 * 1024` and align it with the 
> default documented in `module-info.java`.
> 
> ---------
> - [X] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Volkan Yazici has updated the pull request incrementally with one additional 
commit since the last revision:

  Change the default to 384kB

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/33715/files
  - new: https://git.openjdk.org/jdk/pull/33715/files/4e6ee755..9a9ba3f5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=33715&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=33715&range=02-03

  Stats: 4 lines in 3 files changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/33715.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/33715/head:pull/33715

PR: https://git.openjdk.org/jdk/pull/33715

Reply via email to