On Thu, 5 Nov 2026 12:56:58 GMT, Volkan Yazici <[email protected]> wrote:

>> `src/jdk.httpserver/share/classes/module-info.java` documents that 
>> `sun.net.httpserver.maxReqHeaderSize` defaults to `393216 or 384kB`.
>> This doesn't match the implementation 
>> `sun.net.httpserver.ServerConfig#DEFAULT_MAX_REQ_HEADER_SIZE`, which is `380 
>> * 1024`, i.e., `389120 or 380kB`.
>> 
>> Note that the `jdk.http.maxHeaderSize` system property, used by 
>> `HttpClient`, also defaults to `393216 or 384kB`.
>> The `380` hardcoded in `DEFAULT_MAX_REQ_HEADER_SIZE` is a typo.
>> Fix `DEFAULT_MAX_REQ_HEADER_SIZE` to `384 * 1024` and align it with the 
>> default documented in `module-info.java`.
>> 
>> ---------
>> - [X] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Volkan Yazici has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Shorten the `createRequestHeaderLinesLeavingRoomFor50MoreCharacters` method 
> name

Thank you for the update. This looks good to me.

-------------

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/33715#pullrequestreview-5794407143

Reply via email to