On Tue, 3 Nov 2026 14:25:47 GMT, Daniel Fuchs <[email protected]> wrote:
> Please find here a fix for 8396058: > test/jdk/java/net/httpclient/http2/H2GoAwayPromptConnectionClose.java may > fail intermittently if responseSubscriber is still null when connection close > is processed > The fix for [JDK-8394607](https://bugs.openjdk.org/browse/JDK-8394607) was > not fully complete, leaving a small window of opportunity for this additional > race condition. > > The race can be easily reproduced by using > https://github.com/openjdk/jdk/pull/33697/changes/52c3114ecd048fb7914ae260f32a8471a7bd8c91 > > The final version of the fix removes the hacky offloading and `Thread.sleep` > that was used to trigger the bug reliably while working on the fix. So far, > and without the hacky sleep, I was able to observe the issue twice in the CI > before fixing. It's not very frequent but it does happen. > > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). Marked as reviewed by djelinski (Reviewer). src/java.net.http/share/classes/jdk/internal/net/http/Stream.java line 1550: > 1548: try { > 1549: errorRef.compareAndSet(null, cause); > 1550: if (requestBodySuccessfullySent() && !sched.isStopped() && > !inputQ.isEmpty()) { when handling a RESET_STREAM frame, we complete the request body CF instead; see https://github.com/dfuch/jdk/blob/fc90d30068ac8b7a528621243e68ae51d62038dd/src/java.net.http/share/classes/jdk/internal/net/http/Stream.java#L233. Can we do it here as well? ------------- PR Review: https://git.openjdk.org/jdk/pull/33697#pullrequestreview-5782813210 PR Review Comment: https://git.openjdk.org/jdk/pull/33697#discussion_r4478851268
