> Please find here a fix for 8396058: > test/jdk/java/net/httpclient/http2/H2GoAwayPromptConnectionClose.java may > fail intermittently if responseSubscriber is still null when connection close > is processed > The fix for [JDK-8394607](https://bugs.openjdk.org/browse/JDK-8394607) was > not fully complete, leaving a small window of opportunity for this additional > race condition. > > The race can be easily reproduced by using > https://github.com/openjdk/jdk/pull/33697/changes/52c3114ecd048fb7914ae260f32a8471a7bd8c91 > > The final version of the fix removes the hacky offloading and `Thread.sleep` > that was used to trigger the bug reliably while working on the fix. So far, > and without the hacky sleep, I was able to observe the issue twice in the CI > before fixing. It's not very frequent but it does happen. > > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai).
Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: - Review feedback: no need for requestBodySuccessfullySent(); add tests with delayed request body publication - Merge branch 'master' into H2GoAwayPromptConnectionClose-8396058 - Remove hacky reproducer - Uncomment hacky reproducer - 8396058: test/jdk/java/net/httpclient/http2/H2GoAwayPromptConnectionClose.java may fail intermittently if responseSubscriber is still null when connection close is processed ------------- Changes: - all: https://git.openjdk.org/jdk/pull/33697/files - new: https://git.openjdk.org/jdk/pull/33697/files/fc90d300..470c4bd2 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=33697&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=33697&range=00-01 Stats: 34156 lines in 444 files changed: 20619 ins; 4630 del; 8907 mod Patch: https://git.openjdk.org/jdk/pull/33697.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/33697/head:pull/33697 PR: https://git.openjdk.org/jdk/pull/33697
