On Thu, 5 Nov 2026 16:36:04 GMT, Daniel Fuchs <[email protected]> wrote:
>> Please find here a fix for 8396058: >> test/jdk/java/net/httpclient/http2/H2GoAwayPromptConnectionClose.java may >> fail intermittently if responseSubscriber is still null when connection >> close is processed >> The fix for [JDK-8394607](https://bugs.openjdk.org/browse/JDK-8394607) was >> not fully complete, leaving a small window of opportunity for this >> additional race condition. >> >> The race can be easily reproduced by using >> https://github.com/openjdk/jdk/pull/33697/changes/52c3114ecd048fb7914ae260f32a8471a7bd8c91 >> >> The final version of the fix removes the hacky offloading and `Thread.sleep` >> that was used to trigger the bug reliably while working on the fix. So far, >> and without the hacky sleep, I was able to observe the issue twice in the CI >> before fixing. It's not very frequent but it does happen. >> >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Daniel Fuchs has updated the pull request incrementally with one additional > commit since the last revision: > > Review feedback: explain why we need to lock in connectionClosing Marked as reviewed by djelinski (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/33697#pullrequestreview-5799583620
