On Thu, 5 Nov 2026 09:42:36 GMT, Daniel Jeliński <[email protected]> wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits since the last revision:
>>
>> - Review feedback: no need for requestBodySuccessfullySent(); add tests
>> with delayed request body publication
>> - Merge branch 'master' into H2GoAwayPromptConnectionClose-8396058
>> - Remove hacky reproducer
>> - Uncomment hacky reproducer
>> - 8396058:
>> test/jdk/java/net/httpclient/http2/H2GoAwayPromptConnectionClose.java may
>> fail intermittently if responseSubscriber is still null when connection
>> close is processed
>
> src/java.net.http/share/classes/jdk/internal/net/http/Stream.java line 1550:
>
>> 1548: try {
>> 1549: errorRef.compareAndSet(null, cause);
>> 1550: if (requestBodySuccessfullySent() && !sched.isStopped() &&
>> !inputQ.isEmpty()) {
>
> when handling a RESET_STREAM frame, we complete the request body CF instead;
> see
> https://github.com/dfuch/jdk/blob/fc90d30068ac8b7a528621243e68ae51d62038dd/src/java.net.http/share/classes/jdk/internal/net/http/Stream.java#L233.
> Can we do it here as well?
Good suggestion. This seems to work. I have added some test with a POST body
and POST empty body too.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33697#discussion_r4482954366