On Tue, 10 Nov 2026 18:15:24 GMT, Daniel Fuchs <[email protected]> wrote:

>> By line 1890, we know the server is finished sending on the stream. The 
>> lines check if the client finished too. The client never sends on a 
>> PushedStream instance, and for normal requests it is finished once it is 
>> sent (requestBodyCF.isDone()). In the first request on an upgraded 
>> connection, that is sent before the switch to HTTP2, the requestSent flag 
>> records that the client has finished.
>
> I see. Can you add some comments to make the logic more clear? 
> Also I find the name `isClosed` to be a bit misleading here. Maybe 
> `finReached` or `transmissionFinished` would be a better fit, given what the 
> method is testing.

@dfuch Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33824#discussion_r4529080637

Reply via email to