On Thu, 12 Nov 2026 12:16:46 GMT, Daniel Jeliński <[email protected]> wrote:

>> Roland Mesde has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Feedback from @djelinski V01
>
> src/java.net.http/share/classes/jdk/internal/net/http/frame/FramesDecoder.java
>  line 287:
> 
>> 285:                 extractedBuf = 
>> Utils.sliceWithLimitedCapacity(currentBuffer, extract)
>> 286:                                     .asReadOnlyBuffer();
>> 287:                 slicedToDataFrame = true;
> 
> since you're already cleaning it up, get rid of the entire if/else block and 
> the HPACK comment below, and keep just the extractedBuf assignment.

@djelinski I refactored differently and updated the comment because of the 
implementation notes in HttpResponse.BodySubscriber.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33824#discussion_r4553077187

Reply via email to