On Tue, 10 Nov 2026 19:14:07 GMT, Roland Mesde <[email protected]> wrote:

>> This PR makes the HTTP2 client use MalformedFrame.errorStream. A PRIORITY 
>> frame with an invalid length resets its stream (based on RFC 9113) instead 
>> of closing the connection. In addition, invalid ALTSVC frames are now 
>> skipped.
>> 
>> Low risk - affects handling of malformed PRIORITY and ALTSVC frames.
>> 
>> Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
>> 
>> make test TEST=test/jdk/java/net/httpclient
>> 
>> Results:
>> 
>> [windows-x64-specific-test.log](https://github.com/user-attachments/files/34636337/windows-x64-specific-test.log)
>> [macos-aarch64-specific-test.log](https://github.com/user-attachments/files/34636340/macos-aarch64-specific-test.log)
>> [linux-x64-specific-test.log](https://github.com/user-attachments/files/34636341/linux-x64-specific-test.log)
>> [linux-aarch64-specific-test.log](https://github.com/user-attachments/files/34636342/linux-aarch64-specific-test.log)
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Roland Mesde has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Renamed Stream.isClosed() and added clarification comments

Thanks for the changes. This reads much better. I believe we should also take 
this opportunity to remove the `prepareToRelease` and `slicedToDataFrame` 
variables, as well as the `frameProcessed()` method from the `FramesDecoder`. 
IIRC these were used to return byte buffers to a buffer pool back in the first 
HttpClient incubating implementation. The buffer pool was then removed before 
the `java.net.http` module was made standard in JDK 11, but somehow these 
things were left behind.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/33824#issuecomment-6800031993

Reply via email to