On Wed, 11 Nov 2026 15:33:31 GMT, Daniel Fuchs <[email protected]> wrote:

>> Roland Mesde has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Renamed Stream.isClosed() and added clarification comments
>
> Thanks for the changes. This reads much better. I believe we should also take 
> this opportunity to remove the `prepareToRelease` and `slicedToDataFrame` 
> variables, as well as the `frameProcessed()` method from the `FramesDecoder`. 
> IIRC these were used to return byte buffers to a buffer pool back in the 
> first HttpClient incubating implementation. The buffer pool was then removed 
> before the `java.net.http` module was made standard in JDK 11, but somehow 
> these things were left behind.

@dfuch I updated the test results in the PR description based on the latest 
commit.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/33824#issuecomment-6805500768

Reply via email to