On Mon, 2005-04-25 at 16:41, Robert Story wrote:
> All you've done in the container version of table_data is internally provided
> the structure that the table container expects. I having nothing against that.
> All I'm suggesting is that the API be part of table_container instead of
> table_data2. Do a few wrapper function really warrant a whole new helper?

Yes - if the visible functionality is significantly different.

In terms of public API, the main difference between table_data
and table_container is in terms of how the indexing is handled.
I'd suggest it's less confusing if the two different approaches
are handled by two different helper.

The fact that one of these involves relatively little code
isn't a problem, AFAIC.  I'd rather have smaller helpers that
I can understand easily, rather than try and squeeze two
different approaches into one file.

Compare with scalar vs instance helpers.  The scalar helper
is basically just a wrapper round the instance helper.
That works fine, IMO.

I'm a Bear of Very Little Brain, and Large Files Bother Me!

Dave



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders

Reply via email to