On 18 June 2012 23:10, Wes Hardaker <harda...@users.sourceforge.net> wrote:
> Patch #1 is simple and just increases the shift variable allowing
> for 16 bits of index values instead of the previous 8

+1


> Patch #2 is a bit more complex and creates new integer based index
> API for retrieving indexes and then ensure that they're < 2^SHIFT.

Hmmm.... that's a trickier one.

It's a bit more complex than ideally I'd like at this stage,
but in general I'm tempted to say yes.
  But there are a couple of points of concern:

 -  in the various compatibility routines, there's a statement

        *Index = returnIndex;

     Is it safe to assign an 'int' value to a 'short*' without masking
the value to 16bits?

 -  in the header file, mibII/interfaces.h, the declaration of
    Interface_Scan_NextInt has a first parameter of type 'Int'
    Shouldn't this be 'int'  ?

Dave

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders

Reply via email to