Niels Baggesen <n...@users.sourceforge.net> writes:

> Den 19-06-2012 00:10, Wes Hardaker skrev:
>> Patch #1 is simple and just increases the shift variable allowing for 16
>> bits of index values instead of the previous 8 (which wrapped >256 on
>> some systems).
>
> I would like to see this also masking the index to make sure it does not 
> overflow into the type part.

Well, that's what patch #2 was supposed to do.

>> Patch #2 is a bit more complex and creates new integer based index API
>> for retrieving indexes and then ensure that they're < 2^SHIFT.  If
>> they're greater than that, they're dropped as invalid indexes and the
>> data isn't reported (which is better than a crash).
>
> Any reason for adding the extra api? I would say this is a private api 
> for snmpd, so we are free to change it

I'm pretty sure the interface scanning APIs are heavily used in
3rd-party apps that extend the ifTable.  There are zillions of MIBs that
extend the ifTable and it's a commonly used approach.

>> Please vote on both about whether they should be included into the
>> upcoming 5.5.2 and 5.6.2 releases.
>
> And 5.7

True, but 5.7 doesn't require a vote yet :-)
-- 
Wes Hardaker
Please mail all replies to net-snmp-coders@lists.sourceforge.net

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders

Reply via email to