On Thu, Apr 07, 2022 at 01:24:55AM +0000, Kent Watsen wrote:
> This draft has been moved out of the WG.  Now in shepherd write-up.
> 
> Comments:
> 
> Section 4 is titled "Internet-Specific Derived Types"
> Should it be something like "Internet Protocol Suite Types"?

I do not care much, I now have:

   3.  Core YANG Types . . . . . . . . . . . . . . . . . . . . . . .   6
   4.  Internet Protocol Suite Types . . . . . . . . . . . . . . . .  21

> Many places have "Simplified BSD"
> should be "Revised BSD"

I had already fixed these in the YANG modules, the other two
occurances in the I-D boilerplate are generated by tooling and I will
leave them as is (and this text will be rewritten by the RFC editor
anyway).

> The "description" for "email-address" says:
> "The canonical format of the domain part of an email-address uses lowercase 
> US-ASCII characters.".  
> But I don't see a lowercase-restriction in the pattern.  
> Maybe the description could be clarified?

Canonical format in YANG means you accepted mixed case as valid input
but you report in lowercase as output. The pattern describe the valid
input, not the canonical format subset.

> Note: `pyang --strict -Werror --canonical [email protected]`
> [email protected]:551: error: keyword "length" not in canonical 
> order (see RFC 6020, Section 12)

Fixed.

/js

-- 
Jürgen Schönwälder              Jacobs University Bremen gGmbH
Phone: +49 421 200 3587         Campus Ring 1 | 28759 Bremen | Germany
Fax:   +49 421 200 3103         <https://www.jacobs-university.de/>

_______________________________________________
netmod mailing list
[email protected]
https://www.ietf.org/mailman/listinfo/netmod

Reply via email to