On Mon, 2008-10-27 at 10:17 -0400, Anurag S. Maskey wrote: > I am requesting code review comments for CR 6745288 > (http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6745288). > Bugster will be updated with status and evaluation comments after the > code review. > > The webrev is at: > http://cr.opensolaris.org/~anurag_m/onnv-bug-6745288/
I haven't reviewed this in depth, but I did have one question while browsing the overall changes. There are many operations that either operate on the door fd (operations on persistent configuration) or operate on the dld control fd (operations on temporary configuration). Given that such cases exist where one or the other is never used, I don't see the value in always opening both in dladm_open(). Why not always open the required fd on-demand? -Seb _______________________________________________ networking-discuss mailing list [email protected]
