> > I am requesting code review comments for CR 6745288 > > >> (http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6745288). > > >> Bugster will be updated with status and evaluation comments after the > > >> code review. > > >> > > >> The webrev is at: > > >> http://cr.opensolaris.org/~anurag_m/onnv-bug-6745288/ > > Okay, that's good information. Given that you _always_ try and open the > > door fd on demand in dladm_door_cal(), then I don't see why you bother > > to try and open it in dladm_open(). That code can just be removed I > > think. > > I agree with Seb. As it is, we're opening a descriptor we may not need > *and* we're adding more code to do it. > > DLMGMT_DOOR is opened the first time dladm_door_fd() is called . The webrev and cscope database have been updated.
Thanks, Anurag _______________________________________________ networking-discuss mailing list [email protected]
