I've changed dladm.c so that it uses a global handle rather than each
sub-command opening and closing the handle. The webrev and cscope have
been updated at
http://cr.opensolaris.org/~anurag_m/onnv-bug-6745288/
/net/zhadum.east/export/ws/am223141/checkout-area/onnv-bug-6745288
Thanks,
Anurag
Anurag S. Maskey wrote:
> I am requesting code review comments for CR 6745288
> (http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6745288).
> Bugster will be updated with status and evaluation comments after the
> code review.
>
> The webrev is at:
> http://cr.opensolaris.org/~anurag_m/onnv-bug-6745288/
> For users in SWAN, the cscope'd workspace is at:
> /net/zhadum.east/export/ws/am223141/checkout-area/onnv-bug-6745288
>
> The changes add a handle to libdladm. The handle currently contains
> file descriptors to DLD_CONTROL_DEV and DLMGMT_DOOR. These descriptors
> will greatly reduce the number of open() calls.
>
> A lot of files have been touched, but most of them are just opening the
> handle and passing it to libdladm function calls. Also, when one of the
> callback functions need the handle (e.g. dladm.c:linkprop_callback()),
> other callback functions have also been updated to accept the handle as
> an input argument (e.g. dladm_print_field()).
>
> I'd appreciate comments by the end of this week.
>
> Thanks,
> Anurag
>
> _______________________________________________
> networking-discuss mailing list
> [email protected]
>
_______________________________________________
networking-discuss mailing list
[email protected]
