> >  > >  > rcm_mod_init does not return any error code. When anything fails, 
 > > it 
 > >  > >  > simply returns NULL. This is what all the modules do (e.g. 
 > >  > >  > cmd/rcm_daemon/common/svm_rcm.c).
 > >  > >  > I dont know what else rcm_mod_init can do other than returning 
 > > NULL in 
 > >  > >  > case of failure.
 > >  > >
 > >  > > It cannot produce a warning message via rcm_log_message()?
 > >  > >
 > >  > >   
 > >  > Thats what I meant by a debug message. It could log one by calling 
 > >  > rcm_log_message(RCM_WARNING,......).
 > >
 > > Ah.  A debug message is RCM_DEBUG.
 > >
 > >   
 > I have an updated webrev at 
 > http://cr.opensolaris.org/~vassun08/6793859-commentsfix/
 > 
 > Could you please have a look to check if its alright before I file the RTI?

Please also use dladm_status2str() to report the return value.

-- 
meem
_______________________________________________
networking-discuss mailing list
[email protected]

Reply via email to