Sebastien Roy wrote: > On Fri, 2009-01-30 at 11:18 -0500, Vasumathi Sundaram wrote: > >> Sebastien Roy wrote: >> >>> Looking at the updated webrev, while exiting here is fine, >>> Perror0_exit() isn't appropriate for a dladm_open() failure. That exit >>> function calls perror(), which uses errno to print something meaningful. >>> dladm_open() doesn't set errno, but returns a status code specific to >>> libdladm. >>> >>> -Seb >>> >>> >>> >>> >> Ok. I think I can print an error message to stderr and return instead of >> calling Perror0_exit(). >> > > Sure, please use dladm_status2str() to get a meaningful error to print. > > -Seb > > > Thanks. The updated webrev is in the same location http://cr.opensolaris.org/~vassun08/6793859-commentsfix/
Vasumathi _______________________________________________ networking-discuss mailing list [email protected]
