Re: [networking-discuss] Code Review for 6793859

[Vasumathi Sundaram]

Peter Memishian wrote:
>  > >  > We could print a debug message saying that the dladm handle could not 
> be 
>  > >  > opened and mod_init failed. The rcm_daemon would still be running 
> even 
>  > >  > if a modules fails to initialize and needs to be restarted to do 
>  > >  > anything useful.
>  > >
>  > > I'd think it should be more than a debug message.
>  >
>  > rcm_mod_init does not return any error code. When anything fails, it 
>  > simply returns NULL. This is what all the modules do (e.g. 
>  > cmd/rcm_daemon/common/svm_rcm.c).
>  > I dont know what else rcm_mod_init can do other than returning NULL in 
>  > case of failure.
>
> It cannot produce a warning message via rcm_log_message()?
>
>   
Thats what I meant by a debug message. It could log one by calling 
rcm_log_message(RCM_WARNING,......).
_______________________________________________
networking-discuss mailing list
networking-discuss@opensolaris.org