> > > ::ill
 > >    ADDR     NAME   ILL_WQ TYPE      IPST    FLAGS   REFCNT   IRECNT    
 > > NCECNT
 > 
 > Some comments:
 > - the flags should be printed using some char mnemonic, not as a hex
 >   number (see, for example, the output of ::nce)
 > 
 > - refcnt should not be very large. And usually the irecnt and ncecnt
 >   should als not be very large, so maybe you can shrink the field width
 >   a bit and get more space here.
 > 
 > - I personally would prefer to see the ill name to be left justified,
 >   rather than right justified.

I agree with all of the above.  Some other points:

        * On 64-bit systems, the address is going to require twice the
          field width, so you need to build for that now.

        * The name WQ will suffice.

        * It's essential to indicate which ill is v4 and which is v6.

        * TYPE needs to be printed as an enumeration, not an integer.

        * You might consider a single REFCNT field that tallyies up
          all of the reference counts, but then will display
          broken-up output with -v -- e.g.:

                                   REFCNT
                                        4
                                        |
                                        +-> 2 ILM references
                                            1 IRE reference
                                            1 NCE reference

-- 
meem
_______________________________________________
networking-discuss mailing list
[email protected]

Reply via email to