> > ::ill
>
> ADDR NAME CNT VER WQ UP TYPE FLAGS
> 60012dca688 lo0 0 v4 0 R LOOPB M,V
> 6001479d528 e1000g0 34 v4 60014f13d58 R ETHER M,R
> 60013ac69c8 lo0 2 v6 0 R LOOPB M,V
> 6001479d1a8 e1000g0 20 v6 60016675ad8 R ETHER M
In addition to the points Jim has already raised:
* CNT (and more generally any numbers) should be right-justified.
* The VER and NAME fields collectively provide the external
identity for the ill; I'd expect those fields tobe neighboring
* I understand you're trying to save space, but the new
abbreviations for TYPE seem somewhat arbitrary. Perhaps
space can be saved elsewhere.
> > +----> 0 ill_refcnt
> > 0 ill_ire_cnt
> > 0 ill_nce_cnt
> > 0 ill_ilm_cnt
> > 0 ill_walker_cnt
> >
The usual convention is to also explain what each field is -- e.g.:
+----> 0 ill_refcnt (references from active threads)
0 ill_ire_cnt (references from IREs)
...
Of course, you may need to talk with folks more familiar with this code
to get precise definitions for the fields. (Ideally, these definitions
should also fine their way into the comments in the ill_t structure
itself; the existing comments there are often stale or misleading.)
--
meem
_______________________________________________
networking-discuss mailing list
[email protected]
