James Carlson wrote:
Vasumathi Sundaram writes:
James Carlson wrote:
I fixed another problem in function mask_to_prefixlen(). I introduced a macro to get host-byte-ordered mask values.
What is this other problem that you've fixed?  What was wrong with the
ntohl() call that was there before?  (kmdb issue?)

My x86 nightly had a linker error with ntohl() for kmdb, while sparc build went through. Thats why I had to introduce the macros.
I got successful builds for both now.

OK.  I think a better direction here would be to make sure that the
[hn]to[nh][ls] functions (or macros) are available inside of the mdb
API, since this is unlikely to be the only user, but I guess this is
fine for now.  If you could rename the macro to something that makes
it easier to find in the future (such as "ip_ntohl"), that'd probably
help.

Yes, that's right. I will rename the macro for now.

Thanks
Vasumathi
_______________________________________________
networking-discuss mailing list
[email protected]

Reply via email to