> I removed icmp_status from ndd and added it to mdb. The new webrev is
> here: http://cr.opensolaris.org/~vassun08/mdbmacro-webrev-r4/
>
>
> Files changed:
>
> usr/src/cmd/mdb/common/modules/genunix/genunix.c*
> *usr/src/cmd/mdb/common/modules/genunix/net.c
> usr/src/uts/common/inet/ip/icmp.c
> usr/src/uts/common/inet/ip/ip.c
> usr/src/uts/common/inet/mi.h
Looks good. A few comments on your changes to genunix/net.c (some of
these may apply more broadly to this file):
* Why does netstat_icmp_cb() allocate the conn_t via
mdb_alloc() rather than just allocating it on the stack?
(It's less than 500 bytes).
* 1261, 1276: Needless \'s.
* 1262, 1277: Why not spell out "State"?
* 1271: Extra blank line.
--
meem
_______________________________________________
networking-discuss mailing list
[email protected]
