Peter Memishian writes: > > I removed icmp_status from ndd and added it to mdb. The new webrev is > > here: http://cr.opensolaris.org/~vassun08/mdbmacro-webrev-r4/ > > > > > > Files changed: > > > > usr/src/cmd/mdb/common/modules/genunix/genunix.c* > > *usr/src/cmd/mdb/common/modules/genunix/net.c > > usr/src/uts/common/inet/ip/icmp.c > > usr/src/uts/common/inet/ip/ip.c > > usr/src/uts/common/inet/mi.h > > Looks good. A few comments on your changes to genunix/net.c (some of > these may apply more broadly to this file): > > * Why does netstat_icmp_cb() allocate the conn_t via > mdb_alloc() rather than just allocating it on the stack? > (It's less than 500 bytes).
One has to be pretty careful with stack space. kmdb has a tendency to explode when faced with "big" stack variables -- where "big" isn't very large at all. I agree with allocating it, but allocating it as part of the caller is better. (Besides, I thought the walker already allocated the structure being walked and passed in a pointer to a read-in copy of it, meaning that no mdb_vread on 'kaddr' was necessary ...) -- James Carlson, Solaris Networking <[email protected]> Sun Microsystems / 35 Network Drive 71.232W Vox +1 781 442 2084 MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677 _______________________________________________ networking-discuss mailing list [email protected]
