> > > I removed icmp_status from ndd and added it to mdb. The new webrev is > > > here: http://cr.opensolaris.org/~vassun08/mdbmacro-webrev-r4/ > > > > > > > > > Files changed: > > > > > > usr/src/cmd/mdb/common/modules/genunix/genunix.c* > > > *usr/src/cmd/mdb/common/modules/genunix/net.c > > > usr/src/uts/common/inet/ip/icmp.c > > > usr/src/uts/common/inet/ip/ip.c > > > usr/src/uts/common/inet/mi.h > > > > Looks good. A few comments on your changes to genunix/net.c (some of > > these may apply more broadly to this file): > > > > * Why does netstat_icmp_cb() allocate the conn_t via > > mdb_alloc() rather than just allocating it on the stack? > > (It's less than 500 bytes). > > One has to be pretty careful with stack space. kmdb has a tendency to > explode when faced with "big" stack variables -- where "big" isn't > very large at all.
Hmm, I see quite a few MAXPATHLEN and MAXNAMELEN allocations in other dmods. If there are issues with moderate allocations like this, seems we've got some broader issues to address. (But it seems like this kmdb issue should be fixed in kmdb, not added to the concerns of every dmod author.) -- meem _______________________________________________ networking-discuss mailing list [email protected]
