I have the webrev with all the changes here: http://cr.opensolaris.org/~vassun08/mdbmacro-webrev-final/

and the final incremental webrev is here: http://cr.opensolaris.org/~vassun08/mdbmacro-webrev-r8

Could you please take a look before I file the RTI?

Thanks
Vasumathi

Peter Memishian wrote:
> >> I changed the code as per the suggestions. There wasn't much of a > >> reduction but it looks better now.
 > >>
 > >> webrev: http://cr.opensolaris.org/~vassun08/mdbmacro-webrev-r7/
 > >
 > > OK; I'm happy with it.
 > >
 > > Does this mean the last of the ndd status reports are gone from the
 > > regular networking stack?  If so, then CR 4616660 should be cited
 > > here.
 > >
> > > Yes, all the status reports have been removed. I will cite 4616660 in hg > comments.

The latest webrev looks much better.  A couple final comments on net.c:

        * 1103-1106, 1118-1121: Please reformat so that this isn't      
          scattered over so many lines.

        * 1129: Loading ncb->opts into a variable seems unnecessary.


_______________________________________________
networking-discuss mailing list
[email protected]

Reply via email to