The updated webrev with the comments fixed is here:
http://cr.opensolaris.org/~vassun08/mdbmacro-webrev-r5/
The file changed is : usr/src/cmd/mdb/common/modules/genunix/net.c
thanks
Vasumathi
James Carlson wrote:
Peter Memishian writes:
Hmm, I see quite a few MAXPATHLEN and MAXNAMELEN allocations in other
dmods. If there are issues with moderate allocations like this, seems
we've got some broader issues to address.
It's an accident looking for a place to happen. See:
http://opensolaris.org/jive/thread.jspa?threadID=94576&tstart=0
When it does happen, the results are ugly, hard to predict, and almost
always fatal.
(But it seems like this kmdb
issue should be fixed in kmdb, not added to the concerns of every dmod
author.)
If the problem can be avoided relatively easily, I'd recommend doing
it.
Yes, I agree that kmdb should be smarter here (or maybe redesigned if
that's what's necessary), but adding new commands that just fly apart
when used as directed won't make anybody happy.
_______________________________________________
networking-discuss mailing list
[email protected]
