On Thu, 21 Jun 2001, Justin Erenkrantz wrote:

> This attempts to add the -X functionality back into Apache 2.0.
> I chose the simplest way of implementing this - have -X define a config
> symbol called DEBUG (and you could use -DDEBUG as well).  If the MPMs
> detect this symbol, it should do whatever is necessary for DEBUG mode
> (which isn't necessarily ONE_PROCESS).  ONE_PROCESS and NO_DETACH are
> still available.
>
> This patch also removes the !! in the ap_exists_config_define calls
> as I can't fathom what that is good for.
>
> Comments and suggestions welcomed.  -- justin

As I said when this was originally discussed, I really dislike this.  -X
is the exact same as -DONE_PROCESS.  We now have two ways to get into the
same state.  Yuck!  We made a conscious decision to go with -DONE_PROCESS,
the original goal being to move towards environment variables instead of
command line arguments.  The !! was there by the way, because it solved a
lot of bugs on many platforms.

In all, I am -0.9 for this patch, I won't veto it, but I don't want to see
it in the code.  If we do put the -X back in, then remove -DONE_PROCESS.
Having both is just bogus.

Ryan

_______________________________________________________________________________
Ryan Bloom                              [EMAIL PROTECTED]
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------

Reply via email to