Dai Ngo wrote: > Hi, > > I'd like to have a code review for the change to fix CR 6831781. > > The problem was caused by the current handling of QFULL condition in > rpcmod by delaying 10 secs before returning an error to caller, see > related > CR 6762222. <http://monaco.sfbay/detail.jsf?cr=6762222> > > The fix is to retry dispatching the RPC call, when write queue is > full, in 1 > second interval until the RPC timeout expires and returns error to > caller. > Also replacing the "nfs server not responding..." message with "send > queue > full.." message to help user to identify the problem better. >
Dai, How often will this message spam the console? I understand we had an existing message going to the console, but if you are going from 1 delay of 10s to 10 delays of 1s, I have to wonder if that means 10 more messages? Also, I think you need to do a 'hg reci' - the comment section on the webrev is showing up more than the bug and description. Thanks, Tom > webrev is here: > > http://cr.opensolaris.org/~dain/6831781/ > <http://cr.opensolaris.org/%7Edain/6831781/> > > Thanks, > -Dai > _______________________________________________ > nfs-discuss mailing list > nfs-discuss at opensolaris.org
