Richard Lowe wrote: > Dai Ngo <Dai.Ngo at Sun.COM> writes: > > >> Thomas Haynes wrote: >> >>> Sent from my iPhone >>> >>> On May 5, 2009, at 6:15 PM, Dai Ngo <Dai.Ngo at Sun.COM> wrote: >>> >>> >>>> Tom Haynes wrote: >>>> >>>>> Dai Ngo wrote: >>>>> >>>>>>> Also, I think you need to do a 'hg reci' - the comment section >>>>>>> on the webrev >>>>>>> is showing up more than the bug and description. >>>>>>> >>>>>> could you be more specific on this? >>>>>> >>>>>> >>>>> 6831781 >>>>> <http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6831781> >>>>> "[NFS4] NFS server not responding - still trying" messages during >>>>> heavy TCP traffic >>>>> Modified nfs4_rfscall() to decode returned error code from >>>>> CLNT_CALL() and call >>>>> nfs4_queue_fact() with appropriate nfs4_fact_type_t. >>>>> >>>>> >>>>> You should just have the first line, right? >>>>> >>>>> >>>> Thanks Tom, >>>> >>>> I've been using this format and no one pointed it out until now. >>>> I'll delete all comment lines and just leave the bug number and >>>> the bug description in the future. >>>> >>>> -Dai >>>> >>> Dai, >>> >>> Does that pass 'hg pbchk' ? >>> >> Yes, it does: >> >> > > ... > > >> Comments check: >> >> > > ... > > >> Checking for uncommitted changes: >> Warning: the following files have uncommitted changes: >> usr/src/uts/common/fs/nfs/nfs4_client_debug.c >> usr/src/uts/common/fs/nfs/nfs4_subr.c >> usr/src/uts/common/nfs/nfs4_clnt.h >> usr/src/uts/common/rpc/clnt_cots.c >> >> Checking for merges: >> >> rasta.dainx[525] >> >>> If it does, then perhaps I am the mistaken one. >>> >>> But you do need to collapse the changes into one delta. >>> >> I usually does the commit *after* the webrev and *before* submitting >> the RTI. >> >> > > It looks to me like it's passing only because you haven't committed > anything at all, those comments are just in a wx-like active list, not > from the workspace history. > > If you'd actually committed with freeform comments, it most certainly > should be failing. > Yes, you're correct. I added the comment in the active list to help the review of the webrev. However when doing the commit, I only added the bug number and the exact bug description taken from the CR. This is why I did not have any problem with 'hg pbchk' when doing the RTI.
-Dai > -- Rich >
