Sent from my iPhone

On May 5, 2009, at 6:15 PM, Dai Ngo <Dai.Ngo at Sun.COM> wrote:

> Tom Haynes wrote:
>> Dai Ngo wrote:
>>>
>>>>
>>>> Also, I think you need to do a 'hg reci' - the comment section on  
>>>> the webrev
>>>> is showing up more than the bug and description.
>>> could you be more specific on this?
>>>
>>
>> 6831781 <http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6831781 
>> > "[NFS4] NFS server not responding - still trying" messages during  
>> heavy TCP traffic
>> Modified nfs4_rfscall() to decode returned error code from  
>> CLNT_CALL() and call
>> nfs4_queue_fact() with appropriate nfs4_fact_type_t.
>>
>>
>> You should just have the first line, right?
>>
> Thanks Tom,
>
> I've been using this format and no one pointed it out until now.
> I'll delete all comment lines and just leave the bug number and
> the bug description in the future.
>
> -Dai

Dai,

Does that pass 'hg pbchk' ?

If it does, then perhaps I am the mistaken one.

But you do need to collapse the changes into one delta.

Thanks,
Tom

Reply via email to