Thomas Haynes wrote: > > > Sent from my iPhone > > On May 5, 2009, at 6:15 PM, Dai Ngo <Dai.Ngo at Sun.COM> wrote: > >> Tom Haynes wrote: >>> Dai Ngo wrote: >>>> >>>>> >>>>> Also, I think you need to do a 'hg reci' - the comment section on >>>>> the webrev >>>>> is showing up more than the bug and description. >>>> could you be more specific on this? >>>> >>> >>> 6831781 >>> <http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6831781> >>> "[NFS4] NFS server not responding - still trying" messages during >>> heavy TCP traffic >>> Modified nfs4_rfscall() to decode returned error code from >>> CLNT_CALL() and call >>> nfs4_queue_fact() with appropriate nfs4_fact_type_t. >>> >>> >>> You should just have the first line, right? >>> >> Thanks Tom, >> >> I've been using this format and no one pointed it out until now. >> I'll delete all comment lines and just leave the bug number and >> the bug description in the future. >> >> -Dai > > Dai, > > Does that pass 'hg pbchk' ? Yes, it does:
rasta.dainx[523] pwd /export/home/dain/NFS_BUGS/6831781/onnv-clone/ rasta.dainx[524] hg pbchk Password: remote: Not trusting file /export/onnv-clone/.hg/hgrc from untrusted user onhg, group gk CDDL block check: Copyright check: C style check: Header format check: Java style check: File permission check: Keywords check: Comments check: Checking for new tags: Checking for multiple heads (or branches): Checking for branch changes: RTI check: Checking for uncommitted changes: Warning: the following files have uncommitted changes: usr/src/uts/common/fs/nfs/nfs4_client_debug.c usr/src/uts/common/fs/nfs/nfs4_subr.c usr/src/uts/common/nfs/nfs4_clnt.h usr/src/uts/common/rpc/clnt_cots.c Checking for merges: rasta.dainx[525] > > If it does, then perhaps I am the mistaken one. > > But you do need to collapse the changes into one delta. I usually does the commit *after* the webrev and *before* submitting the RTI. However I notice what I'm doing is different from other webrev's. The format of 'active' file I've been using is: file_path bug_number "description of the bug taken from bugster" Description of changes in this file <<=== this is the different! ex: usr/src/uts/common/rpc/clnt_cots.c 6831781 "[NFS4] NFS server not responding - still trying" messages during heavy TCP traffic Modified clnt_cots_kcallit() to retry dispatching the RPC call, when write queue is full, in 1 second interval until the RPC timeout expires and returns error to caller. Replaced EIO with ENOBUFS error code, in clnt_dispatch_send(), when write queue is full. I see other people use this format: file_path bug_number "description of the bug taken from bugster" ex: usr/src/uts/common/rpc/clnt_cots.c 6831781 "[NFS4] NFS server not responding - still trying" messages during heavy TCP traffic [no description of changes in the file] Thanks, -Dai
