Thank you Mahesh, Tom and Rich for reviewing the change. -Dai
Mahesh Siddheshwar wrote: > Dai Ngo wrote: >> Hi, >> >> Updated webrev to include modification to rfscall(), for NFS v3, to >> decode >> return error from CLNT_CALL() to print appropriate message in system >> log. >> >> URL: http://cr.opensolaris.org/~dain/6831781/ >> <http://cr.opensolaris.org/%7Edain/6831781/> >> > Dai, thanks for making the v3 changes. The changes look good. > > Regards, > Mahesh >> Thanks, >> -Dai >> >> Dai Ngo wrote: >>> Hi, >>> >>> I'd like to have a code review for the change to fix CR 6831781. >>> >>> The problem was caused by the current handling of QFULL condition in >>> rpcmod by delaying 10 secs before returning an error to caller, see >>> related >>> CR 6762222. <http://monaco.sfbay/detail.jsf?cr=6762222> >>> >>> The fix is to retry dispatching the RPC call, when write queue is >>> full, in 1 >>> second interval until the RPC timeout expires and returns error to >>> caller. >>> Also replacing the "nfs server not responding..." message with "send >>> queue >>> full.." message to help user to identify the problem better. >>> >>> webrev is here: >>> >>> http://cr.opensolaris.org/~dain/6831781/ >>> <http://cr.opensolaris.org/%7Edain/6831781/> >>> >>> Thanks, >>> -Dai >>> _______________________________________________ >>> nfs-discuss mailing list >>> nfs-discuss at opensolaris.org >> >> _______________________________________________ >> nfs-discuss mailing list >> nfs-discuss at opensolaris.org >
