Hi Jim, james wahlig wrote: > The code looks functionally correct, however, I was wondering what > criteria you used for the number and duration of retries? This is based on the assumption that the set_clientid_confirm should be sent almost immediately after the set_clientid. Under normal circumstances this piece of code should be rarely executed. If a race condition occurs, a delegation recall happens before the set_clientid_confirm arrives, the change allows about 5 secs (retries) for the set_clientid_confirm to arrive. > > I suppose I could run through the server code and see if there is a > precedent already set, but thought maybe someone on the alias might > know. This is something that Spencer probably would have known off > the top of his head, but I don't. > > Maybe there is a retry variable defined somewhere that we could reuse > instead of creating a new one. I consulted with Jeff, and we did not find any existing configurable variable to use so I created a new one.
Thanks for reviewing the change. -Dai > > Dai, the code looks good, and I'm not requiring a change, just looking > to see if we are being consistent with retries in the server. > > Jim > > Dai Ngo wrote: > >> Hi, >> >> I'd like to have a code review for the change to fix CR 6768607. >> >> The problem was caused by an infinite loop in rfs4_cbinfo_hold(). >> This thread put a hold on the DBE of a rfs4_deleg_state causing the >> reaper >> thread to be delayed (forever). Since the deleg_state table was not >> cleaned, >> this caused the reaper threads of the file and client table to also >> be delayed, >> due to the hold on their DBEs from the deleg_state entries. I added >> detailed >> analysis in the evaluation section of the CR. >> >> The fix is to limit the number of retries to 5 (5 secs). >> >> webrev: http://cr.opensolaris.org/~dain/6768607/ >> <http://cr.opensolaris.org/%7Edain/6768607/> >> CR: http://monaco.sfbay/detail.jsf?cr=6768607 >> >> Thanks, >> -Dai >> _______________________________________________ >> nfs-discuss mailing list >> nfs-discuss at opensolaris.org > >
