Thank you Robert, good convention to follow. I'll wait for any other input and make the update in the final webrev.
-Dai Robert Gordon wrote: > > In general looks good! > > Nits: Feel free to ignore. > > clnt_cots.c: > > line: 2599 and 2607. > make the probe names "krpc__i__conngr..." > > "i" for info, "e" for error ... > > line: 2861 > delete or replace with a DTRACE_PROBE :) > > line 2911 & 2923 > looks like it should be "krpc__e__..." > > line 2931 -> "krpc__i__..." > > > On Jun 20, 2009, at 12:45 AM, Dai Ngo wrote: > >> Hi All, >> >> Based on Mahesh's feedback for previous code review for fixes of >> CR 4953763 & 6216670, here is the updated webrev to address >> CR 6216670 only: >> >> http://cr.opensolaris.org/~dain/6216670-2/ >> <http://cr.opensolaris.org/%7Edain/6216670-2/> >> >> This change increases the TCP send and receive buffer size for all >> kernel RPC client connections, and NFS server connections to 1MB, >> if the default system-wide buffer size is smaller than 1MB. >> >> Passed sanity test with NFS miniPIT. NFS performance testing with >> 1 GigE, 10 GigE and IPoIB over tmpfs were done with good results. >> SNDR testing is in the work. >> >> Fix for CR 4953763 is postponed until we can come up with a >> satisfactory solution. >> >> Thanks, >> -Dai >> >> >> _______________________________________________ >> nfs-discuss mailing list >> nfs-discuss at opensolaris.org >
