Hi Frank,

Thank you for taking a look at the change.

Frank Batschulat (Home) wrote:
> minor nit:
>
> +  * Defaults TCP send and receive buffer size for RPC connections.
> +  * These values can be tuned by /etc/default.
>
> thats probably supposed to be /etc/system, right?
>   
Yes, it should be /etc/system.
>> This change increases the TCP send and receive buffer size for all
>> kernel RPC client connections, and NFS server connections to 1MB,
>> if the default system-wide buffer size is smaller than 1MB.
>>     
>
> the 3 new rpc mod tunables probably ought to get a documentation rfe
> filed to be included in the tunables section ?
>   
I need help on this. Mahesh, what should we do here?
> the default NFSD_TCP_BUFSZ should probably be mentioned in the nfsd(1M)
> man page?
>   
I'm not sure if we need to mentioned the nfsd TCP buffer size in the man 
page;
the user does not need to know the technical details as how the 
connection was
constructed, there are other options with the connection as well such as
TCP_NODELAY, SO_REUSEADDR and these are not currently documented.

Thanks,
-Dai

Reply via email to